Properly handle result of getRelativeToCanonical() #2077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is affecting Windows so a fix of issue oracle#2069 is not certain -- but let's see.
Pull Request Test Coverage Report for Build 2385
💛 - Coveralls |
|
I just verified on windows and it works, merging |
|
A test case that would prevent the regression from reappearing would be nice. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Please consider for integration this patch to fix result handling from
getRelativeToCanonical(). Existing tests cover this change for Linux and Mac. This may or may not be the solution to issue #2069 on Windows, as I could not test on that environment.Thank you.