add the OPENGROK_DEFAULT_PROJECTS env var #2081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladak
force-pushed
the
default_projects
branch
from
976085f
to
f8627e2
Compare
tulinkry
reviewed
Apr 24, 2018
OpenGrok
Outdated
| @@ -311,6 +314,13 @@ DefaultInstanceConfiguration() | |||
| *) ENABLE_PROJECTS="-P" ;; | |||
| esac | |||
|
|
|||
| if [ -n "${ENABLE_PROJECTS}" ]; then | |||
| DEFAULT_PROJECTS="" | |||
| for proj in $( IFS=","; echo ${OPENGROK_DEFAULT_PROJECTS} ); do | |||
There was a problem hiding this comment.
non blocking but wrong indentation
|
The only point for this is if this is really useful because (as far as I remember - this might have changed) this default projects are used only when we don't have any cookies which is:
Neither of this is very often. |
Pull Request Test Coverage Report for Build 2392
💛 - Coveralls |
vladak
force-pushed
the
default_projects
branch
from
f8627e2
to
ddad4dc
Compare
|
True, this only works when there are no cookies. I guess it is a way how to guide first time users a bit. |
|
added some documentation to https://github.com/oracle/opengrok/wiki/Webapp-configuration#default-projects |
|
Yes it is a bit more user friendly 😀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
passthru for the -p option. I don't like that the shell script is a filter to
Indexerhowever until it is rewritten such changes need to happen.