Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate plugin framework #2659

Merged
merged 1 commit into from
Feb 4, 2019
Merged

Conversation

tulinkry
Copy link
Contributor

@tulinkry tulinkry commented Feb 2, 2019

Separating the idea with plugin framework to a dedicated class and making the authorization framework a subclass of it.

depends on #2658
approaches #2588

@tulinkry tulinkry force-pushed the plugin-framework branch 2 times, most recently from 87293d0 to f106645 Compare February 2, 2019 15:27
@coveralls
Copy link

coveralls commented Feb 2, 2019

Pull Request Test Coverage Report for Build 3972

  • 80 of 117 (68.38%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 73.248%

Changes Missing Coverage Covered Lines Changed/Added Lines %
opengrok-indexer/src/main/java/org/opengrok/indexer/framework/PluginClassLoader.java 3 4 75.0%
opengrok-indexer/src/main/java/org/opengrok/indexer/authorization/AuthorizationFramework.java 15 20 75.0%
opengrok-indexer/src/main/java/org/opengrok/indexer/framework/PluginFramework.java 62 93 66.67%
Totals Coverage Status
Change from base Build 3971: 0.01%
Covered Lines: 32799
Relevant Lines: 44778

💛 - Coveralls

@tarzanek tarzanek added this to the 1.2 milestone Feb 4, 2019
 - a class with generic type of the loaded plugins
 - making the authorization framework a subclass of it
approaches oracle#2588
@tarzanek
Copy link
Contributor

tarzanek commented Feb 4, 2019

lgtm

@tarzanek tarzanek merged commit 2fd5ffc into oracle:master Feb 4, 2019
@tulinkry tulinkry deleted the plugin-framework branch February 4, 2019 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants