Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2030 : avoid ReusableStringReader for some analyzers #3038

Closed

Conversation

idodeclare
Copy link
Contributor

Hello,

Let's see if this fixes that issue.

—CF

@tarzanek
Copy link
Contributor

suggester failed?
mmmh

 SuggesterControllerTest.testGetPopularityDataAll:633 

Expected: iterable containing [<topclass=15>, <mynamespace=10>]

     but: No item matched: <topclass=15>

@ahornace any clues?

@tarzanek
Copy link
Contributor

but same fails for the https fix by the bot in #3039 ...
so I'd like to accept both PRs and then look at why suggester fails on Windows
@vladak any concerns?

@vladak
Copy link
Member

vladak commented Feb 12, 2020

The suggester failures are transient and specific to Windows Travis environment, could be caused by a race in tests; tracked by #2704.

Before we merge this I'd like to try this with my unit test (indexing lots of jar files).

@vladak
Copy link
Member

vladak commented Feb 12, 2020

Before we merge this I'd like to try this with my unit test (indexing lots of jar files).

Tried the test from #2030 (comment) , did not help.

@idodeclare idodeclare closed this Feb 14, 2020
@idodeclare idodeclare deleted the bugfix/wrap_strings_for_fields branch February 15, 2020 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants