Minimize reflection into Configuration #3127
Conversation
Pull Request Test Coverage Report for Build 5138
💛 - Coveralls |
| * @param v the input argument | ||
| * @param <V> the type of the input to the operation | ||
| */ | ||
| public <V> void syncWriteConfiguration(ConfigurationValueConsumer<V> consumer, V v) { |
There was a problem hiding this comment.
I'd swap the parameter order cause at it seems more natural to me like this
syncWriteConfiguration(groups, (c, g) -> {
populateGroups(g, new TreeSet<>(getProjects().values()));
c.setGroups(g);
});
as its "value -> consume" that value, rather then "consumer of a value -> value"
There was a problem hiding this comment.
That would mean a line like the following:
syncWriteConfiguration(flag, Configuration::setListDirsFirst);
which seems to invert the important part.
There was a problem hiding this comment.
I'll rename the vague arguments and transpose it as you suggest
| } | ||
|
|
||
| private ResourceLock newWriteUnlocker() { | ||
| return () -> CloseableReentrantReadWriteLock.this.writeLock().unlock(); |
There was a problem hiding this comment.
why this.writeLock().unlock() is not enough?
There was a problem hiding this comment.
Oh that was from the imported implementation. Yes it seems superfluous
| public <V> void syncWriteConfiguration(ConfigurationValueConsumer<V> consumer, V v) { | ||
| try (ResourceLock resourceLock = configLock.writeLockAsResource()) { | ||
| //noinspection ConstantConditions to silence unreference auto-closeable | ||
| assert resourceLock != null; |
There was a problem hiding this comment.
why do you assert this when you're explicitely checking this in write|readLockAsResource?
There was a problem hiding this comment.
That's to silent an annoying Java warning of the auto-closeable not being referenced in the block which was a blocker in IDEA when it runs tests with warnings-as-errors
There was a problem hiding this comment.
what about @SuppressWarnings("unused") ?
There was a problem hiding this comment.
No it’s a very focused warning for auto-closeable
| } | ||
|
|
||
| /** | ||
| * @return a defined {@link ResourceLock} once the {@link #writeLock()} ()} |
| } | ||
| }); | ||
| if (capture[EXCEPTION_INDEX] != null) { | ||
| throw capture[EXCEPTION_INDEX]; |
There was a problem hiding this comment.
the exception here is only translated to throw new WebApplicationException(e, Response.Status.BAD_REQUEST)
can you thro that one here and remove the try block in the caller?
| } | ||
| return result; | ||
| } | ||
|
|
There was a problem hiding this comment.
I don't understand
There was a problem hiding this comment.
I don't know :-D I somehow saw two lines. Nevermind.
|
This is a very good idea with the configuration consumer! |
|
Thank you for taking a look, @tulinkry |
|
@ktulinger, were the changes satisfactory? |
|
Thank you, @tulinkry |
idodeclare
force-pushed
the
feature/minimize_conf_reflection
branch
from
4e2b0c1
to
754ebdf
Compare
|
Just rebasing to ensure it still builds OK, since any new |
|
can Creative Commons Attribution-ShareAlike be merged to CDDL project? |
|
@tarzanek , yes I believe so. It's the license which Stack Overflow uses |
@tarzanek, see e.g. OGKTextField.java. |
|
in such case this can be merged, |
|
Thank you, Lubos! 😄 |
Hello,
Please consider for integration this patch to minimize reflection into
Configurationand shift that logic toConfigurationControllerwhere it's more difficult to avoid given the REST-exposure of all configuration through a single web method.RuntimeEnvironmentcan use functional interfaces to achieve the equivalent of the former reflection without having to identify methods byString; thereby we get compile-time checks.I also imported an auto-disposable wrapper around
Lockso that try-with-resources can be used instead of try-finally.Thank you.