Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid truncation when merging config files #4509

Merged
merged 2 commits into from
Dec 7, 2023

Conversation

vladak
Copy link
Member

@vladak vladak commented Dec 6, 2023

This change introduces output file mandatory parameter to the ConfigMerge utility. As a result the tools will no longer consume its output in order to produce new configuration file, avoiding truncation.

@vladak vladak added tools Python tools docker labels Dec 6, 2023
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Dec 6, 2023
@vladak vladak requested a review from kulikjak December 7, 2023 09:07
Copy link
Member

@kulikjak kulikjak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, (now, I am also a Java reviewer... :))

@vladak vladak merged commit 65d41e6 into oracle:master Dec 7, 2023
9 checks passed
@vladak vladak deleted the config_merge_vs_truncation branch December 7, 2023 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docker OCA Verified All contributors have signed the Oracle Contributor Agreement. tools Python tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants