Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Erlang analyzer #910

Merged
merged 1 commit into from
Mar 18, 2015
Merged

Add Erlang analyzer #910

merged 1 commit into from
Mar 18, 2015

Conversation

trondn
Copy link
Contributor

@trondn trondn commented Mar 18, 2015

This patch is a modification of the patches created by
Haitao Li lihaitao@gmail.com back in 2011 and made available
at https://bitbucket.org/liht/opengrok/branch/erlang-analyzer

The OCA is accepted

This patch is a modification of the patches created by
Haitao Li <lihaitao@gmail.com> back in 2011 and made available
at https://bitbucket.org/liht/opengrok/branch/erlang-analyzer
@lht
Copy link
Contributor

lht commented Mar 18, 2015

I accept and am OK with OCA for this patch.

@tarzanek
Copy link
Contributor

great, I guess we only miss some junits, but that can be done later ... accepting, since Travis passed
@trondn @lht will one of you be available to write a junit for the analyzer so it's covered?

tarzanek added a commit that referenced this pull request Mar 18, 2015
@tarzanek tarzanek merged commit 18901b1 into oracle:master Mar 18, 2015
@tarzanek
Copy link
Contributor

hmm, I accepted an we miss copyrights, ok will add them later
...

@tarzanek tarzanek added this to the 0.13 milestone Mar 18, 2015
@tarzanek
Copy link
Contributor

hmm, one more thing we forgot - add this to SearchHelper.java
into filedescriptions ... will fix with copyright ...

@tarzanek
Copy link
Contributor

see #912

@tarzanek
Copy link
Contributor

alt. I should rewrite in how we generate the filedescriptions - they should come from analyzers, this data should be isolated inside analyzer and not taken from helper class (but helper class should build it from the known analyzer list)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants