22 poolable connections #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this branch allow the Publisher returned by OracleConnectionFactoryImpl.create() to support multiple subscribers, with one connection emitted to each subscriber that subscribes. This behavior has been verified as being the correct implementation of this SPI method; The existing implementation is not correct because it does not support multiple subscribers.
Changes in this branch also add cursor closing verification to the test suite. When a test method "closes" the shared connection, the V$OPEN_CURSOR table is queried and it is verified that no cursors have been left open.