Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider storing openssl prefix in RbConfig::CONFIG["configure_args"] #3170

Closed
eregon opened this issue Jul 21, 2023 · 3 comments
Closed

Consider storing openssl prefix in RbConfig::CONFIG["configure_args"] #3170

eregon opened this issue Jul 21, 2023 · 3 comments

Comments

@eregon
Copy link
Member

eregon commented Jul 21, 2023

See ruby/openssl#650 (comment)

The current approach taken in TruffleRuby is similar to what happens on CRuby when using --with-opt-dir, like ruby-install does it:
https://github.com/postmodern/ruby-install/blob/f4978056b54f6926b5c46d86aae19a90544bdd60/share/ruby-install/ruby/functions.sh#L39

@eregon
Copy link
Member Author

eregon commented Jul 24, 2023

Note: we should be able to revert ruby/openssl#653 when this is fixed.

@eregon
Copy link
Member Author

eregon commented Jul 25, 2023

So interestingly #3174 as it is breaks installing grpc:

./src/core/tsi/ssl/key_logging/ssl_key_logging.h:23:10: fatal error:
'openssl/ssl.h' file not found
#include <openssl/ssl.h>
         ^~~~~~~~~~~~~~~

Because now the include dir of openssl is no longer in cppflags, and grpc extconf.rb doesn't call dir_config("openssl"), and on TruffleRuby grpc doesn't build its own openssl (notably saves a fair amount of build time + other concerns):
https://github.com/grpc/grpc/blob/44864c1589040d5dfcb9c793a070efe51d0fb574/src/ruby/ext/grpc/extconf.rb#L70-L71

We could set both configure_args and cppflags/... but that feels a bit wrong.
Or we could make a PR to use dir_config("openssl") in grpc, that might take a while to get merged & released though.
WDYT @rhenium?

@eregon
Copy link
Member Author

eregon commented Nov 30, 2023

This will be fixed by #3343.

eregon added a commit to eregon/openssl that referenced this issue Dec 1, 2023
…refix on TruffleRuby"

* This reverts commit ca738e7.
* No longer needed since oracle/truffleruby#3170 was fixed.
matzbot pushed a commit to ruby/ruby that referenced this issue Mar 20, 2024
…uffle/openssl-prefix on TruffleRuby"

* This reverts commit ruby/openssl@ca738e7e1357.
* No longer needed since oracle/truffleruby#3170 was fixed.

ruby/openssl@1f641a5604
artur-intech pushed a commit to artur-intech/ruby that referenced this issue Apr 26, 2024
…uffle/openssl-prefix on TruffleRuby"

* This reverts commit ruby/openssl@ca738e7e1357.
* No longer needed since oracle/truffleruby#3170 was fixed.

ruby/openssl@1f641a5604
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant