Kernel#sprintf: don't unconditionally grant encoding validity #1852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old code seems to grant strings with encoding validity when it does not have enough information to make that call. Be defensive and claim we don't know the code range instead.
aardvark179
added
the
in-ci
graalvmbot
pushed a commit
that referenced
this pull request
Dec 10, 2019
…ity (#1852). PullRequest: truffleruby/1179
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old code seems to grant strings with encoding validity when it does not have enough information to make that call. Be defensive and claim we don't know the code range instead.
Shopify#1