PR: ready to be merged - Lifecycle java integ test #923

maggiehe00 · 2019-03-08T20:06:02Z

This PR is to add test to

Create Operator1 and domainOnPVUsingWLST with admin server and 1 managed server if they are not running.
After verifying the domain is created properly, change some properties on domain
resources that would cause servers to be restarted and verify that servers are indeed restarted.
The properties are being tested here are:
env: "-Dweblogic.StdoutDebugEnabled=false"-->
"-Dweblogic.StdoutDebugEnabled=false"
logHomeEnabled: true --> logHomeEnabled: false
includeServerOutInPodLog: true --> includeServerOutInPodLog: false
imagePullPolicy: IfNotPresent --> imagePullPolicy: Never image: "store/oracle/weblogic:12.2.1.3" -- >image: "store/oracle/weblogic:duplicate"

After removing hard sleep, all the ITPodsRestart tests passed at Jenkins job: http://****/view/weblogic-operator/job/weblogic-kubernetes-operator-javatest/1349/

Only failed test is known issue: ITOperator.testDomainOnPVUsingWDT:131->BaseTest.testWLDFScaling

…eg-test merge to the latest develop

integration-tests/src/test/java/oracle/kubernetes/operator/ITOperatorLifecycle.java

integration-tests/src/test/java/oracle/kubernetes/operator/utils/TestUtils.java

integration-tests/src/test/java/oracle/kubernetes/operator/ITOperatorLifecycle.java

integration-tests/src/test/java/oracle/kubernetes/operator/utils/Domain.java

vanajamukkara

Need some minor changes.

… --> one property

integration-tests/src/test/java/oracle/kubernetes/operator/utils/TestUtils.java

anpanigr · 2019-03-20T16:28:11Z

integration-tests/src/test/java/oracle/kubernetes/operator/ITPodsRestart.java

+    Map<String, Object> domainMap = TestUtils.loadYaml(DOMAINONPV_WLST_YAML);
+    domainMap.put("domainUID", "domainpodsrestart");
+    domainMap.put("adminNodePort", new Integer("30707"));
+    domainMap.put("t3ChannelPort", new Integer("30081"));


We do not need set adminNodePort or t3Channel in this usecase

anpanigr · 2019-03-20T16:37:07Z

integration-tests/src/test/java/oracle/kubernetes/operator/ITPodsRestart.java

+   * The property tested is: env: "-Dweblogic.StdoutDebugEnabled=false"-->
+   * "-Dweblogic.StdoutDebugEnabled=true"
+   *
+   * @throws Exception


The Javadoc should describe the usecase more detail as follows ...

Modify the Domain Scoped env property in the Domain Object using kubectl apply -f domain.yaml
Make sure all the Server Pods in the domain got re-started
Reference https://github.com/oracle/weblogic-kubernetes-operator/blob/master/site/server-lifecycle.md

anpanigr · 2019-03-20T16:40:43Z

integration-tests/src/test/java/oracle/kubernetes/operator/utils/Domain.java

@@ -850,6 +850,92 @@ private void createPV() throws Exception {
    new PersistentVolume("/scratch/acceptance_test_pv/persistentVolume-" + domainUid, pvMap);
  }



Need description of the method in javadoc style.

anpanigr · 2019-03-20T16:41:11Z

integration-tests/src/test/java/oracle/kubernetes/operator/utils/Domain.java

+    }
+    logger.info("Done - testDomainServerPodRestart");
+  }
+


Need method description

anpanigr · 2019-03-20T16:41:29Z

integration-tests/src/test/java/oracle/kubernetes/operator/utils/Domain.java

+    TestUtils.checkPodCreated(domainUid + "-" + adminServerName, domainNS);
+    Thread.sleep(10 * 1000);
+  }
+


Need method Description

integration-tests/src/test/java/oracle/kubernetes/operator/utils/TestUtils.java

vanajamukkara · 2019-03-20T19:42:32Z

integration-tests/src/test/java/oracle/kubernetes/operator/ITPodsRestart.java

+          "About to testDomainServerPodRestart for Domain: "
+              + domain.getDomainUid()
+              + "  Image property: store/oracle/weblogic:12.2.1.3 to store/oracle/weblogic:duplicate");
+      TestUtils.dockerTagImage("store/oracle/weblogic:12.2.1.3", "store/oracle/weblogic:duplicate");


you can replace TestUtils.dockerTagImage with TestUtils.exec("docker tag store/oracle/weblogic:12.2.1.3 store/oracle/weblogic:duplicate") and get rid of dockerTag methods.

Almost missed it. Done

vanajamukkara · 2019-03-20T19:43:55Z

integration-tests/src/test/java/oracle/kubernetes/operator/ITPodsRestart.java

+      domain.testDomainServerPodRestart(
+          "\"store/oracle/weblogic:12.2.1.3\"", "\"store/oracle/weblogic:duplicate\"");
+    } finally {
+      TestUtils.dockerRemoveImage("store/oracle/weblogic:duplicate");


replace with TestUtils.exec("docker rmi -f store/oracle/weblogic:duplicate")

Almost missed it. Done

…eg-test

maggiehe00 · 2019-03-22T00:12:08Z

All the ITPodsRestart tests passed at Jenkins job: http://****/view/weblogic-operator/job/weblogic-kubernetes-operator-javatest/1335/

Only failed test is known issue: ITOperator.testDomainOnPVUsingWDT:131->BaseTest.testWLDFScaling

vanajamukkara · 2019-03-22T14:44:23Z

integration-tests/src/test/java/oracle/kubernetes/operator/utils/Domain.java

+                + i
+                + ") is Terminating");
+        TestUtils.checkPodTerminating(domainUid + "-" + managedServerNameBase + i, domainNS);
+        Thread.sleep(10 * 1000);


TestUtils.checkPodCreated() checks in loop. Is the hard sleep needed here?

Yes. This is needed. Between pod Terminating and Running there was a very short period "containerCreating".

Hard sleep is removed.

Locally all the tests passed.

anpanigr · 2019-03-22T18:16:54Z

I am OK with Change based on Jenkin Run
http://****/view/weblogic-operator/job/weblogic-kubernetes-operator-javatest/1335/

maggiehe00 · 2019-03-22T21:35:28Z

After removing hard sleep, all the ITPodsRestart tests passed at Jenkins job: http://****/view/weblogic-operator/job/weblogic-kubernetes-operator-javatest/1349/

Only failed test is known issue: ITOperator.testDomainOnPVUsingWDT:131->BaseTest.testWLDFScaling

anpanigr

PR is ready to merge

MAGGIE.HE@ORACLE.COM added 4 commits March 6, 2019 19:53

initial version for lifecycle-java-integ-test

19cc796

adding class ITOperatorLifecycle

3593b15

minor update

1dd2131

revert ITOperator.java change

72352ae

maggiehe00 requested review from anpanigr and vanajamukkara March 11, 2019 15:55

Merge remote-tracking branch 'origin/develop' into lifecycle-java-int…

7f28204

…eg-test merge to the latest develop

vanajamukkara reviewed Mar 12, 2019

View reviewed changes

integration-tests/src/test/java/oracle/kubernetes/operator/ITOperatorLifecycle.java Outdated Show resolved Hide resolved

vanajamukkara reviewed Mar 12, 2019

View reviewed changes

integration-tests/src/test/java/oracle/kubernetes/operator/utils/TestUtils.java Outdated Show resolved Hide resolved

vanajamukkara reviewed Mar 12, 2019

View reviewed changes

integration-tests/src/test/java/oracle/kubernetes/operator/ITOperatorLifecycle.java Outdated Show resolved Hide resolved

vanajamukkara reviewed Mar 12, 2019

View reviewed changes

integration-tests/src/test/java/oracle/kubernetes/operator/utils/Domain.java Outdated Show resolved Hide resolved

vanajamukkara reviewed Mar 12, 2019

View reviewed changes

MAGGIE.HE@ORACLE.COM added 6 commits March 15, 2019 08:09

change class ITOperatorLifecycle to ITPodsRestart and one test method…

1f6cb0c

… --> one property

remove ITOperatorLifecycle.java

a8ab45d

merge to the latest develop

03bfae9

put removing the testing/temp image logic into finally block

610d307

add README.md

f470f55

minor change

36f5584

vanajamukkara reviewed Mar 18, 2019

View reviewed changes

integration-tests/src/test/java/oracle/kubernetes/operator/utils/TestUtils.java Outdated Show resolved Hide resolved

vanajamukkara reviewed Mar 18, 2019

View reviewed changes

integration-tests/src/test/java/oracle/kubernetes/operator/utils/TestUtils.java Outdated Show resolved Hide resolved

MAGGIE.HE@ORACLE.COM added 3 commits March 18, 2019 19:48

use TestUtil.exec() for command exec

ab77513

use TestUtils.exec to replace kubectl exec

452aca5

correct typo

7b905b7

anpanigr reviewed Mar 20, 2019

View reviewed changes

integration-tests/src/test/java/oracle/kubernetes/operator/utils/TestUtils.java Outdated Show resolved Hide resolved

vanajamukkara reviewed Mar 20, 2019

View reviewed changes

MAGGIE.HE@ORACLE.COM added 4 commits March 20, 2019 18:30

add javadoc style method description

25de2fe

Merge remote-tracking branch 'origin/develop' into lifecycle-java-int…

373f883

…eg-test

remove docker tag/remove methods instead direcly use TestUtils.exec(cmd)

293d869

minor javadoc format change

5d8e9f8

vanajamukkara reviewed Mar 22, 2019

View reviewed changes

remove hard sleep

ac49aa6

vanajamukkara approved these changes Mar 22, 2019

View reviewed changes

anpanigr approved these changes Mar 22, 2019

View reviewed changes

maggiehe00 changed the title ~~WIP: Lifecycle java integ test~~ PR: ready to be merged - Lifecycle java integ test Mar 23, 2019

rjeberhard merged commit 38c807b into develop Mar 25, 2019

rjeberhard deleted the lifecycle-java-integ-test branch April 9, 2019 12:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PR: ready to be merged - Lifecycle java integ test #923

PR: ready to be merged - Lifecycle java integ test #923

maggiehe00 commented Mar 8, 2019 •

edited by rjeberhard

Loading

vanajamukkara left a comment

anpanigr Mar 20, 2019

maggiehe00 Mar 21, 2019

anpanigr Mar 20, 2019

maggiehe00 Mar 21, 2019

anpanigr Mar 20, 2019

maggiehe00 Mar 21, 2019

anpanigr Mar 20, 2019

maggiehe00 Mar 21, 2019

anpanigr Mar 20, 2019 •

edited

Loading

maggiehe00 Mar 21, 2019

vanajamukkara Mar 20, 2019

maggiehe00 Mar 21, 2019

vanajamukkara Mar 20, 2019

maggiehe00 Mar 21, 2019

maggiehe00 commented Mar 22, 2019 •

edited by rjeberhard

Loading

vanajamukkara Mar 22, 2019

maggiehe00 Mar 22, 2019

maggiehe00 Mar 22, 2019

maggiehe00 Mar 22, 2019

anpanigr commented Mar 22, 2019 •

edited by rjeberhard

Loading

maggiehe00 commented Mar 22, 2019 •

edited by rjeberhard

Loading

anpanigr left a comment

		@@ -850,6 +850,92 @@ private void createPV() throws Exception {
		new PersistentVolume("/scratch/acceptance_test_pv/persistentVolume-" + domainUid, pvMap);
		}

PR: ready to be merged - Lifecycle java integ test #923

PR: ready to be merged - Lifecycle java integ test #923

Conversation

maggiehe00 commented Mar 8, 2019 • edited by rjeberhard Loading

vanajamukkara left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

anpanigr Mar 20, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

maggiehe00 commented Mar 22, 2019 • edited by rjeberhard Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

anpanigr commented Mar 22, 2019 • edited by rjeberhard Loading

maggiehe00 commented Mar 22, 2019 • edited by rjeberhard Loading

anpanigr left a comment

Choose a reason for hiding this comment

maggiehe00 commented Mar 8, 2019 •

edited by rjeberhard

Loading

anpanigr Mar 20, 2019 •

edited

Loading

maggiehe00 commented Mar 22, 2019 •

edited by rjeberhard

Loading

anpanigr commented Mar 22, 2019 •

edited by rjeberhard

Loading

maggiehe00 commented Mar 22, 2019 •

edited by rjeberhard

Loading