Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unstable period and lookback #22

Closed
gabrieldodan opened this issue May 4, 2015 · 11 comments
Closed

Unstable period and lookback #22

gabrieldodan opened this issue May 4, 2015 · 11 comments

Comments

@gabrieldodan
Copy link

Hi,

Is there any possibility to set the unstable period for indicators with memories? The unstable period is described here http://ta-lib.org/d_api/ta_setunstableperiod.html

@gabrieldodan
Copy link
Author

Also, would be very useful(maybe on a next release) to export also the lookback functions: TA_SMA_Lookback() , TA_EMA_Lookback() etc

@gabrieldodan gabrieldodan changed the title Unstable period Unstable period and lookback May 9, 2015
@oransel
Copy link
Owner

oransel commented May 23, 2015

Unstable period is added 8797d5b

Please help testing.

@oransel
Copy link
Owner

oransel commented May 23, 2015

Lookback functions are a little tricky. I can't seem to find a way to call them in a generic fashion. Any suggestions?

@gabrieldodan
Copy link
Author

Take a look at TA_GetLookback() function at ta_abstract/ta_abstract.c file, seems it is what you need.

@gabrieldodan
Copy link
Author

Also, I think will be useful if you can implement Synch version of the lookback functions

@oransel
Copy link
Owner

oransel commented May 23, 2015

I agree about the synchronous version of the lookback functions. The TA_GetLookback function retrieves the already set value of the lookback and it is not hard to implement, but there is no generic way of calling the lookback functions. They vary in parameters and they do not accept TA_ParamHolder type variable. We'll have to treat each lookback function as an individual function, which will take a lot of work to integrate. Unless, there is a generic way of calling them and I have not figured out yet.

@gabrieldodan
Copy link
Author

Hi Mus,

Sorry for delay. I have tested a bit the unstable period, seems to be working well. The only thing I can't do is to set unstable period for all indicators. I see no code/id for TA_FUNC_UNST_ALL. Also, seems setting TA_FUNC_UNST_NONE has no effect. Any idea?

Regarding lookback functions. I understand will take a lot of work to implement. But I have noticed that there are many functions that accept same numbers and same type of arguments. For example there are many functions that accept only optInTimePeriod argument. So we can group all functions by number-type of arguments. I think will be just a few groups. Look at candle functions, those that begin with "CDL", those functions accept 0 or 1 arguments, so we will have two groups here. We can assign a lookback function for each group, for example for candle functions with 0 arguments we can assign TA_CDLDOJI_Lookback(). I can help you on grouping functions by number-type of arguments. What you think?

Thanks!

@oransel
Copy link
Owner

oransel commented Aug 23, 2015

Hi Gabriel, looking into this. Sorry about the delay. I'll let you know once there is progress.

@gabrieldodan
Copy link
Author

Hi Mus, no problem regarding delay. Thanks !

@gabrieldodan
Copy link
Author

Hi Mus, let me know if you have any progress on this issue. Thanks!

@oransel
Copy link
Owner

oransel commented Oct 3, 2015

Hi Gabriel, no update yet.

@oransel oransel closed this as completed May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants