Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specification for ORAS attach command #424

Closed
shizhMSFT opened this issue Jun 28, 2022 Discussed in #407 · 5 comments
Closed

Specification for ORAS attach command #424

shizhMSFT opened this issue Jun 28, 2022 Discussed in #407 · 5 comments
Assignees
Milestone

Comments

@shizhMSFT
Copy link
Contributor

Discussed in #407

Originally posted by sajayantony June 10, 2022
Currently the ORAS CLI has a command that pushes an reference type using the subject flag

oras push localhost:5000/alpine \
   --subject localhost:5000/alpine:3.9 \
   --artifact-type doc/example --plain-http \
    ./README.md

I would like to recommend moving this under a new command group attach and credit goes to @jdolitsky for showing this in the OCI working group.

The main idea idea here would be to support both the specification oras-artifacts and OCI reftypes.
The behavior can be determined using a few options -

  1. Querying the extension API to see if we need to support ORAS or use OCI reftype
  2. User passes in a flag like --update-index as per the propsal that might get finally approved.

For e.g.

oras attach --artifact-type doc/example \
       ./README.md \
        localhost:5000/alpine:3.9 \

@FeynmanZhou @shizhMSFT

@shizhMSFT shizhMSFT added this to the v0.14.0 milestone Jun 28, 2022
@qweeah
Copy link
Contributor

qweeah commented Jun 28, 2022

Ack

@shizhMSFT
Copy link
Contributor Author

@qweeah It is related to #326 and #379

@qweeah
Copy link
Contributor

qweeah commented Jun 29, 2022

  1. Querying the extension API to see if we need to support ORAS or use OCI reftype
  2. User passes in a flag like --update-index as per the propsal that might get finally approved.

Since 0.14.0 is targeting for RC1, we should focus on providing attach capability for an RC1-compliant distribution and create a new issue for those two as long term solution.

@qweeah
Copy link
Contributor

qweeah commented Jul 25, 2022

Need to support annotation for oras attach

@shizhMSFT
Copy link
Contributor Author

Closed by #433

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

No branches or pull requests

2 participants