refactor: improve error message on platform mismatch #500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #500 +/- ##
=======================================
Coverage 71.90% 71.90%
=======================================
Files 9 9
Lines 388 388
=======================================
Hits 279 279
Misses 87 87
Partials 22 22 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Zoey Li <zoeyli@microsoft.com>
shizhMSFT
reviewed
Aug 16, 2022
cmd/oras/manifest/fetch.go
Outdated
| } | ||
| if err != nil { | ||
| if errors.Is(err, errdef.ErrNotFound) { | ||
| return fmt.Errorf("no matching manifest was found in %s", opts.targetRef) |
There was a problem hiding this comment.
How do we distinguish tag not found vs. manifest not found vs. platform not found? or do we have a more friendly error message?
There was a problem hiding this comment.
how about: Error: no manifest with platform invalid was found ?
Signed-off-by: Zoey Li <zoeyli@microsoft.com>
TerryHowe
pushed a commit
to TerryHowe/oras
that referenced
this pull request
Feb 2, 2023
Signed-off-by: Zoey Li <zoeyli@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve error message on platform mismatch
Resolves: #498
Signed-off-by: Zoey Li zoeyli@microsoft.com