Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error message on platform mismatch #498

Closed
shizhMSFT opened this issue Aug 16, 2022 · 2 comments · Fixed by #500
Closed

Improve error message on platform mismatch #498

shizhMSFT opened this issue Aug 16, 2022 · 2 comments · Fixed by #500
Assignees
@lizMSFT
Labels
enhancement New feature or request
Milestone
v0.14.0

Comments

@shizhMSFT
Copy link
Contributor

We should improve the error message when the platform is not found and maybe even validate that the platform is invalid.

➜ oras manifest fetch docker.io/library/ubuntu:20.04 --platform invalid
Error: not found
@shizhMSFT shizhMSFT added the enhancement New feature or request label Aug 16, 2022
@shizhMSFT shizhMSFT added this to the v0.14.0 milestone Aug 16, 2022
@shizhMSFT
Copy link
Contributor Author

@lizMSFT Could you help with this?

@lizMSFT
Copy link
Contributor

lizMSFT commented Aug 16, 2022

@lizMSFT Could you help with this?

I will take care of it👌

@lizMSFT lizMSFT mentioned this issue Aug 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lizMSFT lizMSFT

Labels
enhancement New feature or request
Projects
No open projects
ORAS-Planning
Status: Done
Milestone
v0.14.0
Development

Successfully merging a pull request may close this issue.

refactor: improve error message on platform mismatch lizMSFT/oras
2 participants
@shizhMSFT @lizMSFT