Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: simplify e2e scripts and github action #967

Merged
merged 5 commits into from
Jun 9, 2023

Conversation

qweeah
Copy link
Contributor

@qweeah qweeah commented Jun 6, 2023

What this PR does / why we need it:
As follow-up of #926, this PR

  1. uses make to run e2e in Github actions.
  2. simplifies e2e coverage generation process with unnecessary env variables removed.

Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah qweeah changed the title refactor: simplify e2e scripts and github action chore: simplify e2e scripts and github action Jun 6, 2023
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@codecov-commenter
Copy link

codecov-commenter commented Jun 6, 2023

Codecov Report

Merging #967 (bb11474) into main (4bed51a) will not change coverage.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main     #967   +/-   ##
=======================================
  Coverage   81.15%   81.15%           
=======================================
  Files          53       53           
  Lines        2776     2776           
=======================================
  Hits         2253     2253           
  Misses        354      354           
  Partials      169      169           

Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah qweeah marked this pull request as ready for review June 6, 2023 07:41
Copy link
Member

@TerryHowe TerryHowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@qweeah qweeah merged commit 455e8de into oras-project:main Jun 9, 2023
shizhMSFT pushed a commit to shizhMSFT/oras that referenced this pull request Aug 3, 2023
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Co-authored-by: Terry Howe <tlhowe@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants