Skip to content
This repository has been archived by the owner on Sep 30, 2023. It is now read-only.

Reduce test code boilerplate #154

Closed
haadcode opened this issue Aug 23, 2018 · 2 comments
Closed

Reduce test code boilerplate #154

haadcode opened this issue Aug 23, 2018 · 2 comments
Assignees
@haadcode

Comments

@haadcode
Copy link
Member

We currently have a bit of boilerplate to setup the test suite in each test file (requires, variables, starting IPFS, setting up paths/directories etc). We should try to refactor the tests' boilerplate to make it easier to add new tests and maintain existing ones.

We should take a similar approach to OrbitDB as that has worked well and also easily allows us to run the tests against go-ipfs again.
@haadcode haadcode mentioned this issue Aug 23, 2018
Closed
@haadcode haadcode mentioned this issue Aug 31, 2018
Merged
2 tasks
@haadcode
Copy link
Member Author

haadcode commented Sep 4, 2018

Gonna work on this.

@haadcode haadcode self-assigned this Sep 4, 2018
@haadcode haadcode mentioned this issue Sep 4, 2018
Merged
@haadcode
Copy link
Member Author

haadcode commented Sep 4, 2018

This was done in #168.

PRs for further improvements much appreciated!

@haadcode haadcode closed this as completed Sep 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@haadcode haadcode

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@haadcode