Staking Contract v0.3 #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ept addresses and not interfaces
OdedWx
approved these changes
Sep 19, 2019
There was a problem hiding this comment.
approved. Required fixes: (in a separate PR):
Modify events
event Staked(address indexed stakeOwner, uint256 amount, uint256 total_staked_amount);
event Unstaked(address indexed stakeOwner, uint256 amount, uint256 total_staked_amount);
event Restaked(address indexed stakeOwner, uint256 amount, uint256 total_staked_amount);
event Withdrew(address indexed stakeOwner, uint256 amount, uint256 total_staked_amount);
event AcceptedMigration(address indexed stakeOwner, uint256 amount, uint256 total_staked_amount);
distributeRewards:
- Inefficiency of multiple ERC20 transfers, a single transfer is preferred
notifyStakeChange:
if (!address(notifier).call(abi.encodeWithSelector(notifier.stakeChange.selector, _stakeOwner))) {
- Need to set Gas limit to ensure no ability to prevent execution (can be quite a high limit such as 2M GAS)
PartialMigrate
Migrates only part of the staked tokens
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.