-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add types to Python code #450
Comments
Whilst working on this it is good to keep in mind the changes that are introduced in Python3.9, see Pep 585 (deprecating things like typing.Iterable). For the time being we will stay on Python3.8 because of the base images we use for the An example module where we already use type hints is |
i still don't understand how you want this to be resolved |
Hi @balotofi! The idea is to extend gradual typing like this: orchest/services/orchest-webserver/app/app/analytics.py Lines 131 to 133 in b39ded5
To the rest of the codebase. One can start module by module, or package by package, rather than spending a lot of time working on a huge pull request. |
@astrojuanlu I can help with this. Got a preference which part of the codebase should I focus on first? Are we still sticking to typing as it was on Python 3.8 or should I use the standards of Python 3.9? |
Thanks @sbarrios93! We'll continue the conversation about #1216 on the PR itself. About the Python version, I opened #1217. |
Describe the solution you'd like
Add types to Python codebase
What does your solution aim to solve?
Make it more explicit what arguments functions take and therefore make it easier to extend consume or refactor code.
The text was updated successfully, but these errors were encountered: