Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic HTTP header for outbound traffic #24

Open
c0c0n3 opened this issue Jan 28, 2020 · 3 comments
Open

Dynamic HTTP header for outbound traffic #24

c0c0n3 opened this issue Jan 28, 2020 · 3 comments

Comments

@c0c0n3
Copy link
Member

c0c0n3 commented Jan 28, 2020

See: istio/istio#20602

@c0c0n3
Copy link
Member Author

c0c0n3 commented Jan 31, 2020

This blog post:

https://istio.io/blog/2018/egress-monitoring-access-control/

seems to hint that in principle we should be able to have the adapter intercept outbound requests ...

@c0c0n3
Copy link
Member Author

c0c0n3 commented Jan 31, 2020

PR #25 implements a stopgap solution. The various sore points listed there mean in general we're better off replacing PR #25's implementation with the one outlined in istio/istio#20602, if possible. If it turns out it can't be done, then we'll have to deal with the shortcomings of #25. But notice that if we move the whole adapter DAPS config to K8s secret volumes (not just the keys), most of those sore points will be non-issues. See #15.

@c0c0n3
Copy link
Member Author

c0c0n3 commented Aug 5, 2020

So it doesn't look like there's a better solution to this, at least not for Istio 1.4 whereas from 1.5 onwards it can be done relatively easily with WASM, see what the Istio guys replied on 4 Aug 2020.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant