issues with multi entity notification (wrong servicepath created) #208
Assignees
Labels
Comments
chicco785
added a commit
that referenced
this issue
Sep 19, 2020
* added code to group entities by servicepath when multiple notifications arrive at once (#208) * add tests and integration tests (so we have also test with orion triggering such case) * fix notification tests to rely only on api calls (remove call to translator) * changed error code to 400 when due to invalid request * upgraded python to 3.8.5 * fix integration test to use new docker image with entrypoint (#362)
Merged
|
closed by #363 |
chicco785
added a commit
that referenced
this issue
Sep 22, 2020
* added code to group entities by servicepath when multiple notifications arrive at once (#208) * add tests and integration tests (so we have also test with orion triggering such case) * fix notification tests to rely only on api calls (remove call to translator) * changed error code to 400 when due to invalid request * upgraded python to 3.8.5 * fix integration test to use new docker image with entrypoint (#362)
c0c0n3
added a commit
that referenced
this issue
Sep 25, 2020
* fix #208 * added code to group entities by servicepath when multiple notifications arrive at once (#208) * add tests and integration tests (so we have also test with orion triggering such case) * fix notification tests to rely only on api calls (remove call to translator) * changed error code to 400 when due to invalid request * upgraded python to 3.8.5 * fix integration test to use new docker image with entrypoint (#362) * minor fixes * remove build (we can assume a build is available) * remove volumes at the end of the test * increase timesleep for one test * improve code * fix #347 * fix wrong delete logic not keeping into account correctly servicePath!=None * add test for #347 bug * add test for selective service path delete * add drop all also to single entity delete if table is empty * fix tests to correctly delete entities with service paths * dont drop table when deleting entities, use a separate endpoint for that. * factor out common http code from delete module. * make delete api work w/ any translator. * keep timescale version in env var as done for other services. * temp solution to automate delete tests for timescale, ditch when timescale support is complete. * use droptable query param to drop entity table instead of separate endpoint. Co-authored-by: c0c0n3 <andrea.falconi@gmail.com>
c0c0n3
added a commit
that referenced
this issue
Sep 25, 2020
* fix #208 * added code to group entities by servicepath when multiple notifications arrive at once (#208) * add tests and integration tests (so we have also test with orion triggering such case) * fix notification tests to rely only on api calls (remove call to translator) * changed error code to 400 when due to invalid request * upgraded python to 3.8.5 * fix integration test to use new docker image with entrypoint (#362) * minor fixes * remove build (we can assume a build is available) * remove volumes at the end of the test * increase timesleep for one test * improve code * minor fixes * fix timeing for notifications * fix error message check * add tests to produce a similar case as #353 * use only from * use from in combination with last * put building of docker image back in load test. * fix backward compat test. Co-authored-by: c0c0n3 <andrea.falconi@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
When a multiple notification is sent, the service path created is a comma separated version of all servicepaths of the entities.
It could be that the header sent by orion is exactly that. We should then split it and attach it one for entity.
Environment (please complete the following information):
The text was updated successfully, but these errors were encountered: