fix-353 #364
Merged
fix-353 #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* added code to group entities by servicepath when multiple notifications arrive at once (#208) * add tests and integration tests (so we have also test with orion triggering such case) * fix notification tests to rely only on api calls (remove call to translator) * changed error code to 400 when due to invalid request * upgraded python to 3.8.5 * fix integration test to use new docker image with entrypoint (#362)
* remove build (we can assume a build is available) * remove volumes at the end of the test * increase timesleep for one test * improve code
* fix timeing for notifications * fix error message check
* use only from * use from in combination with last
|
#363 need to be merged first |
|
@chicco785 if you could please rebase on master since #363 just got merged :-) |
|
rebase completed |
c0c0n3
reviewed
Sep 22, 2020
c0c0n3
previously approved these changes
Sep 25, 2020
c0c0n3
approved these changes
Sep 25, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add test to produce similar case as #353