Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passthru migration notes to command #3

Closed
crynobone opened this issue Jul 10, 2014 · 4 comments
Closed

Passthru migration notes to command #3

crynobone opened this issue Jul 10, 2014 · 4 comments
Assignees
Milestone

Comments

@crynobone
Copy link
Member

No description provided.

@crynobone crynobone self-assigned this Jul 10, 2014
@crynobone crynobone modified the milestones: v2.2.0, v2.2.x Jul 10, 2014
@neyl
Copy link

neyl commented Aug 28, 2014

When will you be doing this please? I am planning to use tenanti in project but really want to be able to use --pretend to preview sql. I currently extended Migrator class, bound it with App::bind() and added function and outputing $this->notes from there. Very hacky!

@neyl
Copy link

neyl commented Aug 28, 2014

Another issue - using --pretend fails as migration stub adds up($id, $entity) which are not passed forward by getQueries() in migrator so up() method fails with missing params. So again I added getQueries to my extended class with $migration->$method() changed to $migration->$method($this->entity->getKey(), $this->entity). You have to do the same in your Migrator class.

@crynobone
Copy link
Member Author

You could submit a PR and speed things up

@crynobone
Copy link
Member Author

Done on 2.2.x@dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants