Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write more tests #4

Closed
OrderAndCh4oS opened this issue Oct 1, 2018 · 2 comments
Closed

Write more tests #4

OrderAndCh4oS opened this issue Oct 1, 2018 · 2 comments

Comments

@OrderAndCh4oS
Copy link
Owner

The coverage so far is for the scoring system. It'd be great to get some more test coverage in other areas.

If anyone is interested in writing some tests, please do.

@OrderAndCh4oS OrderAndCh4oS changed the title Create more tests Write more tests Oct 1, 2018
@zbendas
Copy link
Contributor

zbendas commented Oct 4, 2018

Hi! I'm interested in giving some test writing a shot. I've gone ahead and forked the repo and started some work. Anything I should keep in mind or look out for while tinkering? I'm new to open source, but came here from your post over on dev.to!

@OrderAndCh4oS
Copy link
Owner Author

Hey, thanks so much, nice to meet you.

Start with stuff that you can easily understand, then just make sure that when you enter the data the method spits out the desired result. Don't overthink it, keep it simple.

Some parts like the players turns and inputs will be a pain to test, so if there is a method that expects user input leave it be for now. These need to be broken up at some point to make them more testable. If you have any ideas how I can separate the view layers, I'm all ears on that too.

If you think you see anything that can be improved (believe me it can all be improved), please let me know I'm open to all suggestions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants