-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make dudect more portable? #33
Comments
It's fairly easy to add this support, we follow the recipe from https://github.com/itzmeanjan/criterion-cycles-per-byte/blob/a270a49652eabf5be9366866613f905f604a18ba/src/lib.rs#L61-L74. It's on my todo list. |
@itzmeanjan awesome to hear that! Looking forward to your contribution :) |
Let me know if I should try rebasing and sending a PR with the diffs from my fork. :) |
Ah that would be wonderful! Thank you! I believe it'd be mainly a matter of integrating d708aca#diff-22b09f555b924f80b50f3449369c7edb176b83494871b9cc133164c080e91c18 . @itzmeanjan previously expressed interest in this. @itzmeanjan : are you still interested in this? We can take @dfaranha 's code as starting point. BTW happy to see you here Diego :) |
I'll send a PR tomorrow @oreparaz. |
I tried rebasing with latest HEAD, but my fork is too old and there are lots of conflicts. I also do not have an ARM device ready to test right now, but will have one in a couple of weeks! |
No worries @dfaranha ! Thanks for that. @itzmeanjan : your PR looks great! I have a bunch of testing to do with that PR but from a code review it looks awesome! let's talk in the PR |
We could make dudect more portable and support other architectures, like ARM. @dfaranha wrote a port to ARM here https://github.com/dfaranha/dudect-arm that we could integrate. I think ARM would be the first target.
The text was updated successfully, but these errors were encountered: