Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chips #120

Closed
panvourtsis opened this issue Nov 30, 2020 · 1 comment · Fixed by #137
Closed

Chips #120

panvourtsis opened this issue Nov 30, 2020 · 1 comment · Fixed by #137
Assignees
Labels
enhancement New feature or request released

Comments

@panvourtsis
Copy link
Collaborator

panvourtsis commented Nov 30, 2020

Description

This will be a brand new component that will be used in inner DS component but outside DS as well

Design

The design can be found here
image

Implementation

This will be a new simple component.

  • It could take as color any color from the flat palette
  • Outline property that will be only bordered
  • Any children will be rendered inside.
  • Two sizes will be provided small and normal (props) - check button for reference
  • left icon - a component to define something on the left
  • right icon - >>
  • right icon, left icon click handlers
  • There will be a border property eg bordered when filled - border rule
fill color: 100-400 
border color: fill color darken by 50%
fill color 500-700
border color: fill color lighten by 50%

Testing

  • Test that children are rendering
  • Test color is rendering correctly
  • Test handlers are being called when icons are clicked
  • Test that color type is rendering correctly
@panvourtsis panvourtsis added the enhancement New feature or request label Nov 30, 2020
@kouloumos kouloumos self-assigned this Dec 8, 2020
@kouloumos kouloumos mentioned this issue Dec 9, 2020
@github-actions
Copy link

🎉 This issue has been resolved in version 1.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants