Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eigen rays are not correct #11

Closed
ZHANGGU opened this issue Oct 26, 2018 · 8 comments
Closed

Eigen rays are not correct #11

ZHANGGU opened this issue Oct 26, 2018 · 8 comments
Assignees
Labels

Comments

@ZHANGGU
Copy link

ZHANGGU commented Oct 26, 2018

Hei

Great python package!

I tried scenarios as shown by the figures, the eigen rays are not correct somehow.

  1. It is wrong in env setup, as the Rx is below the bottom, but it gives all rays.

rays_37km

  1. It should not give all rays.
    rays_46km

By the way, using Bokeh plot is resource consuming, and it takes much time to give a figure of low resolution in saving it. While it is much faster in zoom-in/out

Thanks

@mchitre mchitre self-assigned this Oct 26, 2018
@ZHANGGU
Copy link
Author

ZHANGGU commented Oct 26, 2018

2018-10-26_08-14-35

@mchitre
Copy link
Member

mchitre commented Oct 26, 2018

Thanks for the feedback.

I don't know the exact setup you used, but it looks like the environment parameters you are using is generating too many rays. You may wish to only generate eigenrays rather than all rays. In any case, please refer to Bellhop documentation on how the modeling is controlled by the parameters, as all arlpy does is wrap Bellhop, and does not do the ray computations itself. Do note that eigenray computation in Bellhop gives a set of rays that pass close to the receiver (not necessarily exact).

As for use of Bokeh, I take your point on it being resource intensive for graphs with lots of data. I am evaluating use of Plotly instead of Bokeh, but haven't made that decision yet.

@ZHANGGU
Copy link
Author

ZHANGGU commented Oct 26, 2018 via email

@ZHANGGU
Copy link
Author

ZHANGGU commented Oct 26, 2018

Hi
Do you have detailed Bellhop manual? I can see one manual of 2011 on the web.

Thanks.

@mchitre
Copy link
Member

mchitre commented Oct 26, 2018

Yes, I believe the 2011 one is the most recent one that I know of.

@ZHANGGU
Copy link
Author

ZHANGGU commented Oct 30, 2018

Hi, I did read the 2011 manual which is an intro really. I am still wondering at you would have the intro about output data structures. If yes, could you please share? As my simulations as shown are not correct at all. I am stucked in getting the correct rays. Appreciate your help!

@mchitre
Copy link
Member

mchitre commented Nov 1, 2018

The original acoustics toolbox has a number of MATLAB scripts to deal with the output. Those are the best source of information on the output formats for me, as they are current and work. My Python implementations were based on that, and as far as I can tell from the use cases I use it for, that seems to work fine.

@ZHANGGU
Copy link
Author

ZHANGGU commented Nov 1, 2018

Thanks. I will take look about the m-codes. while I would not expect people enjoy such eigen ray plot as shown :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants