Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[generator][indexer] include collection_times in map data (no display/edit yet) #7950

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

RedAuburn
Copy link
Sponsor Member

@RedAuburn RedAuburn commented Apr 18, 2024

working in parts to make it easier to review & work on.
This PR only includes it into the map data, no user-facing display yet.

part of #2431

@RedAuburn RedAuburn requested review from vng and biodranik April 18, 2024 16:01
initial inclusion to make an implementation easier
Signed-off-by: Harry Bond <me@hbond.xyz>
@RedAuburn
Copy link
Sponsor Member Author

RedAuburn commented Apr 23, 2024

Further work kind of blocked by #7974, as parsing should be done through whatever lib we use.

Maybe we can just display the collection_times as text for now? It'd still be useful in that form

@Misalf-git
Copy link

Misalf-git commented Apr 23, 2024

It'd still be useful in that form

Indeed

Copy link
Member

@biodranik biodranik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will it be displayed properly in the UI? Does our UI support displaying single-time values, not ranges?

And what about the editor? It should have a different UI, right?

Which OSM objects have this feature?

@RedAuburn
Copy link
Sponsor Member Author

RedAuburn commented Apr 26, 2024

Will it be displayed properly in the UI? Does our UI support displaying single-time values, not ranges?

Eventually yes, but as mentioned I think it's kind of blocked by #7974. The current proposal is to just display as the raw values eg. Mo-Fr 09:00; Sa 12:00. As collection time strings are usually relatively simple, and it's really useful information.

And what about the editor? It should have a different UI, right?

only slightly, instead of selecting a to-from time, it would just be a single point.

Which OSM objects have this feature?

the big one is amenity=post_box, 45% (169,103 post boxes) have it tagged. it's particularly well tagged in the UK.
also it's used for recycling etc.

Copy link
Member

@biodranik biodranik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok to add it to generator now and properly add into the UI/editor later. @vng WDYT?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants