transit/world_feed/test: allow git repo configuraion #7983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The world_feed_integration_tests clone a repo during the test phase. Downloading data is forbidden in some distributions (like Gentoo) during building and testing phase. With this patch, TEST_DATA_REPO_URL can be set externally, thus preventing a network connection by providing a locally vendored repo. Signed-off-by: Gerion Entrup <gerion.entrup@flump.de>
biodranik
approved these changes
Apr 25, 2024
|
Yes and no. As a normal user, the OMaps binary probably is enough. Anyway, the current ebuild does not reflect this (which does not matter that much since it is not official). So for now, we could just ignore the side binaries. AFAIK, however, for an official Gentoo package (one in gentoo/gentoo), tests and other binaries matter. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The world_feed_integration_tests clone a repo during the test phase. Downloading data is forbidden in some distributions (like Gentoo) during building and testing phase. With this patch, TEST_DATA_REPO_URL can be set externally, thus preventing a network connection by providing a locally vendored repo.