[Indicator] my MA example

[cgava]

Hello

To learn and understand both MT4 and EA31337 I've created my own indi_ma implementation. I have some issues/questions:

1. Is this implementation OK ?
2. There is computation difference between this way of computing the MA and the MA.mq5 provided by EA31337-Indicators, which has also differences with Builtin MA and Custom Moving Average.mq4 Metaquote example (see Issue#20

struct Indi_myma_Params : IndicatorParams {
    int period;
    ENUM_APPLIED_PRICE applied_price;

    Indi_myma_Params(unsigned int _period=20, ENUM_APPLIED_PRICE _applied_price=PRICE_CLOSE) {
        period = _period;
        applied_price = _applied_price;
    }
};

class Indi_myma : public Indicator<Indi_myma_Params> {
public:
    Indi_myma(Indi_myma_Params &p, IndicatorBase *indi_src = NULL) : Indicator<Indi_myma_Params>(p, indi_src) {};
    
    virtual IndicatorDataEntryValue GetEntryValue(int _mode = 0, int _shift = -1) {
        // computation of the MA using only the CopyClose function
        Indi_myma_Params iparams = GetParams();
        int barCount=GetBars();
        GetLogger().Trace(StringFormat("barCount: %d", barCount), __FUNCTION_LINE__);
        double buf[];
        if (_shift + 1 + iparams.period >= barCount) {
            GetLogger().Trace(StringFormat("Not enough values _shift: %d, iparams.period=%d", _shift, iparams.period), __FUNCTION_LINE__);
            return EMPTY_VALUE; // Or any appropriate value
        }

        int cnt = CopyClose(GetSymbol(), GetTf(), _shift, iparams.period, buf);
        if (cnt < iparams.period) {
            GetLogger().Error("CopyClose failed, retrieved only %d values", __FUNCTION_LINE__);
            return EMPTY_VALUE;
        }

        double res=0.0;
        for(int i=0; i<iparams.period; i++) {
            res+=buf[i];
        }
        res=res/iparams.period;
        return res;
    }
};

[kenorb]

At the first look, the code seems to be fine. Is it works better than Indi_MA implementation? What issues do you've with it?