Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The Wire.endTransmission after Wire.requestFrom is not needed. #4

Closed
Koepel opened this issue Jun 16, 2017 · 2 comments
Closed

The Wire.endTransmission after Wire.requestFrom is not needed. #4

Koepel opened this issue Jun 16, 2017 · 2 comments

Comments

@Koepel
Copy link

Koepel commented Jun 16, 2017

In the file "i2c.h" in the function "read" is a Wire.endTransmission at the end, after a Wire.requestFrom.
That last Wire.endTransmission can be deleted, since Wire.requestFrom should not be followed by a Wire.endTransmission.

The Wire.beginTransmission and Wire.endTransmission are only used when writing data.
@jlvandusen
Copy link

Koepel - thank you

@orgua
Copy link
Owner

orgua commented Nov 19, 2022

ok, changed in latest dev-branch

@orgua orgua closed this as completed Nov 19, 2022
@orgua orgua mentioned this issue Nov 20, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@orgua @Koepel @jlvandusen