-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SecretKeyFactory PBKDF2WithHmacSHA1 implementation not found #31
Comments
Let us check for this issue. Which samsung device exactly are you using and android version? |
samsung GT-S5282 - 4.1.2 |
And samsung GT-I9100G - 4.1.2 |
Same problem in my app:
It happens on these devices : This is a great library but it cannot be used on a production app used by a lot of people. The crash rate increase really quickly with that crash. |
I started working on this issue, apparently some devices don't have this algorithm. I think today I'll create a new version with the fix |
Thanks a lot ! If you need more info, I will be glad to help you |
i have same problem too, thanks a lot. We are waiting for new build :) |
Soon, there will be a new release, I'll update this post for the snapshot version, if it works we can release it. Thanks for the feedback really. |
@aligurelli @Christophe668 @csechuan @sakirk I uploaded a new snapshot version with a fallback fix, could you try with this please? I don't have these devices and cannot test properly unfortunately, I just did some mockup. snapshot version is repositories {
maven { url "https://oss.sonatype.org/content/repositories/snapshots/"}
}
dependencies {
compile 'com.orhanobut:hawk:1.7-SNAPSHOT'
} If everything works properly, I'll put a new release. |
Thx. Will test it out. You replace encryption with conceal? |
@csechuan no, I didn't use conceal, I just added a fallback to another key generation. I also updated the snapshot version with a new quick fix. Please try below. repositories { maven { url "https://oss.sonatype.org/content/repositories/snapshots/"} } dependencies { compile 'com.orhanobut:hawk:1.9-SNAPSHOT' } |
Thx @orhanobut. Unfortunately I don't have a device affected by this issue so if I release this update it would be launched on a large set of user. Do you think it is stable enough to be released on a production app with a large set of user? |
Best would be to wait for the release version. I also dont have these devices but gonna check this at work. This should fix this issue permanently but still need a good test. I will keep to update this post. It would be great if someone check this version as well :( |
So far so good. |
@csechuan Do you have this problem anymore so far? That would be great feedback if you have tried and test it in a device that was affected this issue, Thanks |
Has a little problem. Caused by java.lang.NullPointerException |
I think the secretkeyfactory problem is solved, today I'll release a new build including this NPE. |
Wait. Not yet. E/AndroidRuntime﹕ FATAL EXCEPTION: pool-2-thread-1 |
Can you try without proguard? and can you also tell me which android version? you may need to add some config in the proguard. I tested in a few devices, had no problem at all. Can you also tell me how do you init hawk? |
@csechuan I think this issue is related to something, can we move this issue to another thread please? While creating issue, could you also show me the exception without proguard if possible and also the value might be null? |
Ok. I found out the problem is with Gson itself. Gson cant serialize / deserialize enums after pro-guarded, so have to make exceptions on those enum thingy. |
That's great news. I'll close this issue. @csechuan thanks for testing. |
Thank you @orhanobut for this fix and @csechuan for testing ! |
Thanks for creating this.
I am trying to use Hawk in one of my projects but getting the bellow error on some Samsung devices:
java.lang.RuntimeException: java.security.NoSuchAlgorithmException: SecretKeyFactory PBKDF2WithHmacSHA1 implementation not found
Any workaround for that?.
Thanks.
The text was updated successfully, but these errors were encountered: