-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Continue playing previous sound instead of cutting it when the next key is pressed #46
Comments
Sounds good. Are you interested in making a draft PR? I think we should implement this first to test the new behavior. Then we can discuss making this configurable. |
I would wait with this till #24 is done, as we might need to touch the way sound is played for the pitch thing. |
Makes sense. |
I played around with this and some stuff does not sound great. The default profile release sounds for example. Maybe this needs a configurable number of sounds that can be played concurrently. |
I have primitive knowledge working with I have not looked at this repo before tonight but it doesn't seem too large. I might make a PR for this soon. |
…key is pressed Fixed orhun#46
* 🐛Continue playing previous sound instead of cutting it when the next key is pressed Fixed #46 * refactor: clean up code --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Orhun Parmaksız <orhunparmaksiz@gmail.com>
Is your feature request related to a problem? Please describe.
When a new key is pressed while the previous sound is still playing the old sound is stopped
Describe the solution you'd like
The old sound should continue playing at the same time as the new.
Describe alternatives you've considered
Additional context
I created this as a feature request, as both behaviours are valid. This should be configurable, but default should be to continue playing.
The text was updated successfully, but these errors were encountered: