Distinct sound for keys

[orhun]

Is your feature request related to a problem? Please describe.

For the default preset, having a distinct sound for each key press would be an interesting feature. Maybe it might even sound more realistic.

Describe the solution you'd like

n/a
Ideas welcome.

Describe alternatives you've considered

n/a

Additional context

https://www.reddit.com/r/linux/comments/16xu9ek/comment/k37m3qj/?utm_source=share&utm_medium=web2x&context=3

[Xenira]

While I like this idea and this seems to be more of a fun project I think it is worth to consider the security implications of this.

With this active it would be possible to figure out passwords (and other inputs) based on the sounds played.

For more realism it might be possible to randomly alter pitch and speed by a little bit.

[orhun]

Yup, you are definitely right.

For more realism it might be possible to randomly alter pitch and speed by a little bit.

Sounds good! Are you interested in raising a PR? 🐻

[Xenira]

I will try, but not sure how to do this yet. Haven't done any sound processing in rust yet.

[orhun]

Got it, let me know when you have progress! I can hop in to help if needed.

[Xenira]

Sure, Ill create a draft for config/cli interface first and then see how well I can manage the rest.

[Xenira]

Got volume and speed running without much of a problem. There seems to be no option for pitch though.

Any feedback on what I've got so far would be appreciated.

Will do docu and cleanup once everything else is in place.

[orhun]

Thanks! Do you think we can use an external library for changing the pitch? Maybe process the audio at runtime before feeding it into the sink?

[Xenira]

Guess that is highly dependent on the audio formats we want to support.

Also performance might be a consideration. If there is one that can do this using streams I am all for it.

[orhun]

I think we're only supporting MP3 for now. I will look into if possible to do so.

[Xenira]

After some research I think it might not be worth the effort to add the pitch shift option. In fact the speed option should already modify the pitch. Time independent pitch shifting seems to be a little more on the complex side. But I have basically no knowledge on music theory.

There are no big libraries (as far as I could tell) that implement those algorithms.

My proposal would be to either

1. Drop pitch entirely
2. Create mp3's that are already pitch shifted and add them to the preset

[Xenira]

Removed pitch (#44 (comment))