Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(config): add option to disable easter eggs #48

Merged
merged 5 commits into from
Oct 18, 2023

Conversation

Xenira
Copy link
Sponsor Contributor

@Xenira Xenira commented Oct 15, 2023

Description of change

Add no_surprises to config file and --no-surprises to cli.

The ak preset can still be activated by using the pseset name. Maybe add an easter egg for selecting that preset with easter eggs disabled 🤔

Closes #45

How has this been tested? (if applicable)

  • Inverted the condition on the easter egg and tested with / without disabled.

@Xenira Xenira requested a review from orhun as a code owner October 15, 2023 19:50
@codecov-commenter
Copy link

codecov-commenter commented Oct 15, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Files Coverage Δ
src/args.rs 41.66% <0.00%> (+5.30%) ⬆️
src/config.rs 32.03% <0.00%> (ø)
src/main.rs 0.00% <0.00%> (ø)

📢 Thoughts on this report? Let us know!.

@Xenira Xenira changed the title feat(config): Add option to disable easter egs feat(config): Add option to disable easter eggs Oct 15, 2023
Copy link
Owner

@orhun orhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect. Thanks!

@orhun orhun changed the title feat(config): Add option to disable easter eggs feat(config): add option to disable easter eggs Oct 18, 2023
@orhun orhun merged commit 7d347ad into orhun:main Oct 18, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support disabling easter eggs
3 participants