Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(args): allow returning the bumped version #362

Merged
merged 2 commits into from
Dec 4, 2023

Conversation

nappa85
Copy link
Contributor

@nappa85 nappa85 commented Dec 1, 2023

Description

This PR adds a CLI command to simply return the bumped version, solves #361

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (no code change)
  • Refactor (refactoring production code)
  • Other

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have formatted the code with rustfmt.
  • I checked the lints with clippy.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@nappa85 nappa85 requested a review from orhun as a code owner December 1, 2023 13:59
@codecov-commenter
Copy link

codecov-commenter commented Dec 1, 2023

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (c94cb6a) 44.29% compared to head (81254c7) 43.40%.

Files Patch % Lines
git-cliff/src/lib.rs 0.00% 16 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #362      +/-   ##
==========================================
- Coverage   44.29%   43.40%   -0.89%     
==========================================
  Files          13       13              
  Lines         630      643      +13     
==========================================
  Hits          279      279              
- Misses        351      364      +13     
Flag Coverage Δ
unit-tests 43.40% <0.00%> (-0.89%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@orhun orhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had some comments - please check 🐻

Can you also add fixture tests for testing the output?

git-cliff/src/args.rs Show resolved Hide resolved
git-cliff/src/lib.rs Outdated Show resolved Hide resolved
website/docs/usage/examples.md Outdated Show resolved Hide resolved
@nappa85 nappa85 force-pushed the feat/allow_returning_bumped_version branch 2 times, most recently from 8b86d7b to 54ccc94 Compare December 4, 2023 09:44
@nappa85 nappa85 force-pushed the feat/allow_returning_bumped_version branch from 54ccc94 to ede7e8b Compare December 4, 2023 09:51
Copy link
Owner

@orhun orhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! 💖

@orhun orhun changed the title feat: allow returning bumped version feat(args): allow returning the bumped version Dec 4, 2023
@orhun orhun merged commit 5e01e4c into orhun:main Dec 4, 2023
26 checks passed
@nappa85
Copy link
Contributor Author

nappa85 commented Dec 4, 2023

Thanks for your contribution! 💖

Thank you for your patience

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants