Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docker): make keywords uppercase #344

Merged
merged 1 commit into from
Aug 31, 2024
Merged

Conversation

tessus
Copy link
Collaborator

@tessus tessus commented Aug 31, 2024

Description

The 'as' keyword should match the case of the 'from' keyword

FromAsCasing: 'as' and 'FROM' keywords' casing do not match
More info: https://docs.docker.com/go/dockerfile/rule/from-as-casing/

Motivation and Context

gh action produces a warning. see here: https://github.com/orhun/rustypaste/pull/343/files#diff-dd2c0eb6ea5cfc6c4bd4eac30934e2d5746747af48fef6da689e85b752f39557

How Has This Been Tested?

  • waiting for the CI to complete.

Changelog Entry

### Fixed

- Dockerfile: The 'as' keyword should match the case of the 'from' keyword

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (no code change)
  • Refactor (refactoring production code)
  • Other

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have formatted the code with rustfmt.
  • I checked the lints with clippy.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

The 'as' keyword should match the case of the 'from' keyword

FromAsCasing: 'as' and 'FROM' keywords' casing do not match
More info: https://docs.docker.com/go/dockerfile/rule/from-as-casing/
@tessus tessus requested a review from orhun as a code owner August 31, 2024 08:08
@orhun orhun changed the title fix(docker): keywords should be uppercase fix(docker): make keywords uppercase Aug 31, 2024
@orhun orhun merged commit 82ea9f1 into orhun:master Aug 31, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants