Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: When is this plugin considered "ready"? #95

Open
mstoetzer opened this issue May 23, 2022 · 1 comment
Open

Question: When is this plugin considered "ready"? #95

mstoetzer opened this issue May 23, 2022 · 1 comment

Comments

@mstoetzer
Copy link

The CoreDNS /ready endpoint will return HTTP 200, when all plugins are loaded See this.

Can this endpoint used to check if all ingress hostnames are loaded into the index?

I want to use the /ready endpoint in a readinessProbe to add this CoreDNS instance to the service endpoints only when the entries are ready. Startup time could be a few seconds and I want to avoid any downtime of the CoreDNS.

@networkop
Copy link
Collaborator

Yep, this should be fairly easy to add. The ready plugin should already be baked into the binary and all that we're missing is a file similar to this one https://github.com/coredns/coredns/blob/5b9b079dabc7f71463cea3f0c6a92f338935039d/plugin/kubernetes/ready.go
Do you want to do a PR @mstoetzer ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants