Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add implementations for SHA256 and SHA384 #152

Closed
brycx opened this issue Dec 9, 2020 · 1 comment
Closed

Add implementations for SHA256 and SHA384 #152

brycx opened this issue Dec 9, 2020 · 1 comment
Labels
breaking change A breaking change new feature New feature or request
Milestone
v0.16

Comments

@brycx
Copy link
Member

brycx commented Dec 9, 2020

SHA256 is used widely, if not more than SHA512. SHA384 is not used as much AFAIK, except for TLS 1.3. It would be nice to add these two, to offer a more complete feature-set of the SHA2-family.

This is labeled a breaking change because it is expected that the current SHA512 implementation along with the above two, will be gathered under a new sha2 module in hazardous::hash. This way, we avoid later breaking changes when, at some point, SHA3 is added.
@brycx brycx added new feature New feature or request breaking change A breaking change labels Dec 9, 2020
@brycx brycx added this to the v0.16 milestone Dec 9, 2020
This was referenced Dec 9, 2020
Closed
Closed
@brycx brycx mentioned this issue Dec 22, 2020
Merged
2 tasks
@brycx
Copy link
Member Author

brycx commented Dec 29, 2020

Added in a8d6920. Will be included in version 0.16.

@brycx brycx closed this as completed Dec 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change A breaking change new feature New feature or request
Projects
None yet
Milestone
v0.16
Development

No branches or pull requests
1 participant
@brycx