Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug] assigning params with a default config does not merge #6

Closed
itsmichaelbtw opened this issue Oct 21, 2022 · 1 comment
Closed

[bug] assigning params with a default config does not merge #6

itsmichaelbtw opened this issue Oct 21, 2022 · 1 comment
Assignees
@itsmichaelbtw
Labels
bug Something isn't working

Comments

@itsmichaelbtw
Copy link
Owner

Describe the bug
When setting a default param value using the global urbex.configure provider, it does not merge but rather gets overwritten by the params value if one is passed when calling urbex[method]
@itsmichaelbtw itsmichaelbtw added the bug Something isn't working label Oct 21, 2022
@itsmichaelbtw itsmichaelbtw self-assigned this Oct 21, 2022
itsmichaelbtw pushed a commit that referenced this issue Oct 24, 2022
fix: params not serializing correctly #6
a5cf0c2
@itsmichaelbtw
Copy link
Owner Author

addressed in v2.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@itsmichaelbtw itsmichaelbtw

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@itsmichaelbtw