Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

noImplicitAny for ui/analysis, ui/puzzle, ui/round #6939

Closed
3 tasks done
niklasf opened this issue Jul 5, 2020 · 4 comments
Closed
3 tasks done

noImplicitAny for ui/analysis, ui/puzzle, ui/round #6939

niklasf opened this issue Jul 5, 2020 · 4 comments
Labels
chore good first issue Narrow in scope (but not necessarily easy) no scala

Comments

@niklasf
Copy link
Member

niklasf commented Jul 5, 2020 •
edited by benediktwerner
Loading

noImplicitAny will help with some refactorings (such as lichess-org/chessground#145). Even partial progress is useful.

  1. Pick one of:

    • ui/analyse
    • ui/puzzle
    • ui/round

  2. Temporarily set noImplicitAny to true in ui/.../tsconfig.json.

  3. To compile use yarn run dev, yarn run dev --watch or yarn run tsc --noEmit in ui/.... Fix some issues. (Usually it is better to leave issues unsolved than making any explicit).

  4. Turn noImplicitAny back off, unless no issues remain.
@niklasf niklasf added good first issue Narrow in scope (but not necessarily easy) chore no scala labels Jul 5, 2020
@niklasf niklasf changed the title noImplicitAny for ui/puzzle noImplicitAny for ui/analysis, ui/puzzle, ui/round Jul 5, 2020
greg-finley added a commit to greg-finley/lila that referenced this issue Jul 6, 2020
@greg-finley
Types for ui/puzzle, for lichess-org#6939
fe2eb66
ornicar added a commit that referenced this issue Jul 6, 2020
@ornicar
Merge pull request #6941 from greg-finley/uipuzzle
0510222 
Types for ui/puzzle, for #6939
@niklasf niklasf mentioned this issue Jul 7, 2020
Merged
9 tasks
@abhigyank
Copy link

Is ui/puzzle complete by #6941? Can we tick it in the description if it is so :)

@greg-finley
Copy link
Contributor

Nope, there were still a few I wasn’t able to add types for.

niklasf added a commit that referenced this issue Jul 11, 2020
@niklasf
finish noImplicitAny for ui/puzzle (#6939)
8af0371
greg-finley added a commit to greg-finley/lila that referenced this issue Jul 11, 2020
@greg-finley
Types for ui/round for lichess-org#6939
4d8a1e5
ornicar added a commit that referenced this issue Jul 15, 2020
@ornicar
Merge pull request #6974 from greg-finley/uiround2
b428035 
Types for ui/round for #6939
ornicar added a commit that referenced this issue Jul 15, 2020
@ornicar
Merge branch 'master' of github.com:ornicar/lila
430f1bf 
* 'master' of github.com:ornicar/lila:
  Remove k? thing
  optimize PairingRepo.lastOpponents (#6988)
  Hide the scrollbar on the lobby graph
  Types for ui/round for #6939
lizlecrone referenced this issue in lizlecrone/lila Sep 7, 2020
Types for ui/round for ornicar#6939
b4a9ce6
@lizlecrone lizlecrone mentioned this issue Sep 7, 2020
Merged
ornicar referenced this issue Sep 7, 2020
@ornicar
Merge pull request #7250 from lizlecrone/uiround
67fb163 
Types for ui/round for ornicar#6939
ornicar referenced this issue Sep 7, 2020
@ornicar
Merge branch 'master' of github.com:ornicar/lila into master
83cf730 
* 'master' of github.com:ornicar/lila:
  New Crowdin updates (#7245)
  Types for ui/round for ornicar#6939
This was referenced Oct 16, 2020
Merged
Merged
@domlupo domlupo mentioned this issue Oct 25, 2020
Closed
@mrguiman mrguiman mentioned this issue Nov 18, 2020
Merged
@benediktwerner benediktwerner mentioned this issue Apr 17, 2021
Merged
@SeppeSoete SeppeSoete mentioned this issue Apr 22, 2021
Merged
@benediktwerner
Copy link
Member

As of #8713 ui/analyse now also has noImplicitAny: true. Though ui/round and maybe also ui/puzzle still have a few places where typing could be improved e.g. by replacing explicit anys with proper types.

@niklasf
Copy link
Member Author

niklasf commented Apr 25, 2021

Awesome, thanks! I feel like those can be done on demand, i.e., when changing related code.

@niklasf niklasf closed this as completed Apr 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chore good first issue Narrow in scope (but not necessarily easy) no scala
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@niklasf @benediktwerner @abhigyank @greg-finley