Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting or CLI argument to hide volume button #16

Closed
orontee opened this issue Jun 14, 2022 · 1 comment · Fixed by #17
Closed

Setting or CLI argument to hide volume button #16

orontee opened this issue Jun 14, 2022 · 1 comment · Fixed by #17
Labels
enhancement New feature or request
Milestone
v1.1.0

Comments

@orontee
Copy link
Owner

orontee commented Jun 14, 2022 •
edited
Loading

Wondering whether the client can request the server to learn whether the software mixer is used or not...

Suggested through #14.
@orontee orontee added the enhancement New feature or request label Jun 14, 2022
This was referenced Jun 14, 2022
Closed
Merged
@orontee orontee linked a pull request Jun 14, 2022 that will close this issue
Option to hide volume button and translations update #17
Merged
@orontee
Copy link
Owner Author

orontee commented Jun 15, 2022 •
edited
Loading

I disabled audio mixer in Mopidy conf and saw that core.mixer.get_volume returns null in that case. So, I think the option isn't needed, one can automatically hide the volume button when such a value is returned.

I've implemented automatic visibility of volume button, depending on the core.mixer.get_volume response. We don't need the option anymore.

@orontee orontee added this to the v1.1.0 milestone Jun 15, 2022
@orontee orontee mentioned this issue May 14, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging a pull request may close this issue.

Option to hide volume button and translations update orontee/argos
1 participant
@orontee