-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keys not recorded in YML on first run. #175
Comments
@orta ping? |
We're hitting this too; would you be interested in merging a pull request to fix this? |
Yeah, for sure. We've just always re-ran |
@ileitch do you want to open a pull request from your fork? :) |
Fixed by #192 and shipped in 2.0.7 |
Awesome, thanks @orta :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Given a simple Podfile config:
and an empty macOS keychain and no files generated in ~/.cocoapods/keys, I can demonstrate that the
TophatHmacKey
is not recorded in the generated YML, and thus is not included in the generated ObjC class.In a nutshell, this commit from @colinta makes no sense: 7743a9b
It appears the reasoning for the commit is that we need to re-save the keychain if the user was prompted and provided a value for a missing key. However, saving of a new key is performed here & here which loads and saves its own instance of
CocoaPodsKeys::Keyring
. Once all missing key values have been provided and saved the line from the commit is executed which saves aKeyring
instanced created before the missing keys were saved. The end result is that the YML is overwritten with an emptykeys
array.This output should make things more clear:
Note: the final call in
setup
has line 75 in the backtrace, this is due my debugging modifications. The line number without any modifications is 68.Perhaps there used to be some caching of
Keyring
instances that made this work previously, but it seems to be now that 7743a9b should be reverted.There appears to be at least one other bug report of this incorrect behavior: #153
The text was updated successfully, but these errors were encountered: