Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate broken SVGs #153

Closed
aeneasr opened this issue May 21, 2019 · 4 comments · Fixed by #154
Closed

Investigate broken SVGs #153

aeneasr opened this issue May 21, 2019 · 4 comments · Fixed by #154

Comments

@aeneasr
Copy link
Member

aeneasr commented May 21, 2019

It appears to be an issue with minification?
@aeneasr
Copy link
Member Author

aeneasr commented May 21, 2019

Confirmed, caused by image minifcation

@aeneasr
Copy link
Member Author

aeneasr commented May 21, 2019

This is a bug in docusaurus, it's not possible to disable svg imagemin in docusaurus due to another bug. Related issue facebook/docusaurus#1427

Basically we've got to wait for 1.9.1.

@aeneasr
Copy link
Member Author

aeneasr commented May 21, 2019

/cc @kevgo

aeneasr added a commit that referenced this issue May 21, 2019
@aeneasr
Disable svg minification and fix broken link
a639b97 
Closes #153
@aeneasr aeneasr mentioned this issue May 21, 2019
Merged
aeneasr added a commit that referenced this issue May 21, 2019
@aeneasr
Disable svg minification and fix broken link
5eff0a9 
Closes #153
@kevgo
Copy link
Contributor

kevgo commented May 21, 2019

Ah, nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Disable svg minification and fix broken link ory/docs
2 participants
@kevgo @aeneasr