Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ability to allow token refresh from hook without overriding the session claims #863

Merged
merged 1 commit into from
Jun 17, 2022

Conversation

zachabney
Copy link
Contributor

@zachabney zachabney commented Jun 11, 2022

Documentation corresponding to PR ory/hydra#3146

The refresh token hook currently requires a 200 response code with an updated session payload. There is no way to permit the token refresh without overriding the session data. It's useful, however, to be able to use the token refresh hook in order to accept/reject token refreshes without the need to update the session data.

This adds the ability for the token refresh hook to return a 204 No Content response code to indicate that the token refresh is permitted, but not to update the session data.

Related Issue or Design Document

ory/hydra#3082

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability. If this pull request addresses a security
    vulnerability, I confirm that I got green light (please contact security@ory.sh) from the
    maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary documentation within the code base (if appropriate).

@aeneasr aeneasr changed the base branch from master to hydra-v2.x June 17, 2022 14:44
@aeneasr aeneasr merged commit 3843eff into ory:hydra-v2.x Jun 17, 2022
tomekpapiernik pushed a commit that referenced this pull request Oct 7, 2022
tomekpapiernik pushed a commit that referenced this pull request Oct 12, 2022
aeneasr pushed a commit that referenced this pull request Oct 27, 2022
aeneasr pushed a commit that referenced this pull request Oct 27, 2022
aeneasr pushed a commit that referenced this pull request Oct 27, 2022
@achedeuzot
Copy link
Contributor

Hey, strangely enough, merging this commit removed the changes brought in PR #1019
I'm not sure that was expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants