Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add link to comic-book about OAuth2 to docs #1064

Closed
wants to merge 1 commit into from
Closed

feat: add link to comic-book about OAuth2 to docs #1064

wants to merge 1 commit into from

Conversation

achedeuzot
Copy link
Contributor

This was merged in #1019 but was later removed when merging #863

This PR re-adds the change in #1019. It's still strange why it was removed, but some changed might have been accidentally removed on other occasions.

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact security@ory.sh) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

@aeneasr
Copy link
Member

aeneasr commented Nov 7, 2022

Hello, after a review we decided not to include the linked blog post in our documentation because we felt it does not add additional value to our documentation. Thank you though for your contribution!

@achedeuzot
Copy link
Contributor Author

Oh okay. Too bad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants