Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Always return non-error response for inactive tokens #517

Merged
merged 1 commit into from
Oct 25, 2020

Conversation

mitar
Copy link
Contributor

@mitar mitar commented Oct 21, 2020

Proposed changes

One of our unit tests caught that after upgrade to latest fosite.

I introduced the regression with #479 but existing fosite tests didn't catch it. The problem is that when returning ErrInactiveToken from NewIntrospectionRequest we now wrap underlying error, which can happen to be ErrRequestUnauthorized.

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got green light (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary documentation within the code base (if appropriate).

@aeneasr aeneasr merged commit 5f2cae3 into ory:master Oct 25, 2020
@mitar mitar deleted the fix-introspection-error branch October 25, 2020 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants