Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: golang build 1.18 by upgrading dependency golang.org/x/sys #41

Merged
merged 1 commit into from
Mar 23, 2022

Conversation

f-blass
Copy link
Contributor

@f-blass f-blass commented Mar 22, 2022

Go build failed with go 1.18 with the following error:

# golang.org/x/sys/unix
../../pkg/mod/golang.org/x/sys@v0.0.0-20200602225109-6fdc65e7d980/unix/syscall_darwin.1_13.go:29:3: //go:linkname must refer to declared function or variable
../../pkg/mod/golang.org/x/sys@v0.0.0-20200602225109-6fdc65e7d980/unix/zsyscall_darwin_amd64.1_13.go:27:3: //go:linkname must refer to declared function or variable
../../pkg/mod/golang.org/x/sys@v0.0.0-20200602225109-6fdc65e7d980/unix/zsyscall_darwin_amd64.1_13.go:40:3: //go:linkname must refer to declared function or variable
../../pkg/mod/golang.org/x/sys@v0.0.0-20200602225109-6fdc65e7d980/unix/zsyscall_darwin_amd64.go:28:3: //go:linkname must refer to declared function or variable
../../pkg/mod/golang.org/x/sys@v0.0.0-20200602225109-6fdc65e7d980/unix/zsyscall_darwin_amd64.go:43:3: //go:linkname must refer to declared function or variable
../../pkg/mod/golang.org/x/sys@v0.0.0-20200602225109-6fdc65e7d980/unix/zsyscall_darwin_amd64.go:59:3: //go:linkname must refer to declared function or variable
../../pkg/mod/golang.org/x/sys@v0.0.0-20200602225109-6fdc65e7d980/unix/zsyscall_darwin_amd64.go:75:3: //go:linkname must refer to declared function or variable
../../pkg/mod/golang.org/x/sys@v0.0.0-20200602225109-6fdc65e7d980/unix/zsyscall_darwin_amd64.go:90:3: //go:linkname must refer to declared function or variable
../../pkg/mod/golang.org/x/sys@v0.0.0-20200602225109-6fdc65e7d980/unix/zsyscall_darwin_amd64.go:105:3: //go:linkname must refer to declared function or variable
../../pkg/mod/golang.org/x/sys@v0.0.0-20200602225109-6fdc65e7d980/unix/zsyscall_darwin_amd64.go:121:3: //go:linkname must refer to declared function or variable
../../pkg/mod/golang.org/x/sys@v0.0.0-20200602225109-6fdc65e7d980/unix/zsyscall_darwin_amd64.go:121:3: too many errors

@CLAassistant
Copy link

CLAassistant commented Mar 22, 2022

CLA assistant check
All committers have signed the CLA.

@f-blass f-blass changed the title Upgrade dependency golang.org/x/sys fix: Fix golang build 1.18 by upgrading dependency golang.org/x/sys Mar 22, 2022
@f-blass f-blass changed the title fix: Fix golang build 1.18 by upgrading dependency golang.org/x/sys fix: golang build 1.18 by upgrading dependency golang.org/x/sys Mar 22, 2022
@f-blass
Copy link
Contributor Author

f-blass commented Mar 23, 2022

@aeneasr fyi

Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make these changes only about upgrading the dependencies and remove the changes to cmd/root

@f-blass
Copy link
Contributor Author

f-blass commented Mar 23, 2022

Sorry, fixed.

@aeneasr aeneasr merged commit cb007b7 into ory:master Mar 23, 2022
@aeneasr
Copy link
Member

aeneasr commented Mar 23, 2022

ty!

@aeneasr aeneasr self-assigned this Mar 23, 2022
@f-blass
Copy link
Contributor Author

f-blass commented Mar 23, 2022

@aeneasr Could you please also tag a new version? Thank you!

@aeneasr
Copy link
Member

aeneasr commented Mar 23, 2022

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants