Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update x/sys to support go 1.17 #2687

Merged
merged 1 commit into from
Aug 23, 2021
Merged

chore: Update x/sys to support go 1.17 #2687

merged 1 commit into from
Aug 23, 2021

Conversation

gordonbondon
Copy link
Contributor

Updating x/sys so that this project supports go 1.17.

More context: Homebrew/homebrew-core#83413

Without this fix running a binary can cause a panic, see upstream go issue: golang/go#45702

Related issue(s)

Checklist

@CLAassistant
Copy link

CLAassistant commented Aug 20, 2021

CLA assistant check
All committers have signed the CLA.

@gordonbondon
Copy link
Contributor Author

I can't replicate test failure locally, so seems unrelated:

$ go test ./... -run='TestManagers/package=consent/janitor=mysql' -tags sqlite -failfast -timeout=20m
?   	github.com/ory/hydra	[no test files]
ok  	github.com/ory/hydra/client	4.353s [no tests to run]
ok  	github.com/ory/hydra/cmd	3.103s [no tests to run]
ok  	github.com/ory/hydra/cmd/cli	3.563s [no tests to run]
?   	github.com/ory/hydra/cmd/clidoc	[no test files]
ok  	github.com/ory/hydra/cmd/server	1.884s [no tests to run]
ok  	github.com/ory/hydra/consent	6.166s [no tests to run]
ok  	github.com/ory/hydra/driver	2.241s [no tests to run]
ok  	github.com/ory/hydra/driver/config	0.467s [no tests to run]
?   	github.com/ory/hydra/health	[no test files]
?   	github.com/ory/hydra/internal	[no test files]
?   	github.com/ory/hydra/internal/httpclient/client	[no test files]
?   	github.com/ory/hydra/internal/httpclient/client/admin	[no test files]
?   	github.com/ory/hydra/internal/httpclient/client/metadata	[no test files]
?   	github.com/ory/hydra/internal/httpclient/client/public	[no test files]
?   	github.com/ory/hydra/internal/httpclient/models	[no test files]
?   	github.com/ory/hydra/internal/testhelpers	[no test files]
ok  	github.com/ory/hydra/jwk	5.076s [no tests to run]
ok  	github.com/ory/hydra/oauth2	5.683s [no tests to run]
?   	github.com/ory/hydra/persistence	[no test files]
ok  	github.com/ory/hydra/persistence/sql	369.437s
ok  	github.com/ory/hydra/persistence/sql/migratest	2.789s [no tests to run]
?   	github.com/ory/hydra/spec	[no test files]
?   	github.com/ory/hydra/test/mock-cb	[no test files]
?   	github.com/ory/hydra/test/mock-client	[no test files]
?   	github.com/ory/hydra/test/mock-lcp	[no test files]
ok  	github.com/ory/hydra/x	6.971s [no tests to run]
ok  	github.com/ory/hydra/x/oauth2cors	4.249s [no tests to run]

@aeneasr
Copy link
Member

aeneasr commented Aug 23, 2021

Yup, it's a flaky test! I'll re-run the CI now

@codecov
Copy link

codecov bot commented Aug 23, 2021

Codecov Report

Merging #2687 (31152e0) into master (3d08e96) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2687      +/-   ##
==========================================
+ Coverage   52.69%   52.71%   +0.01%     
==========================================
  Files         234      234              
  Lines       14040    14040              
==========================================
+ Hits         7399     7401       +2     
+ Misses       6013     6012       -1     
+ Partials      628      627       -1     
Impacted Files Coverage Δ
persistence/sql/persister_oauth2.go 83.66% <0.00%> (+0.79%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d08e96...31152e0. Read the comment docs.

@aeneasr aeneasr merged commit 57b41e9 into ory:master Aug 23, 2021
@gordonbondon gordonbondon deleted the upgrade-sys-go117 branch August 24, 2021 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants