feat(tracing): add deeper tracing #3125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aeneasr let me know if there are any other code paths that I missed that need tracing. :) |
aeneasr
approved these changes
May 25, 2022
|
tests probably need a bit of love ;) otherwise LGTM |
Codecov Report
@@ Coverage Diff @@
## v2.x #3125 +/- ##
=======================================
Coverage ? 78.75%
=======================================
Files ? 112
Lines ? 8385
Branches ? 0
=======================================
Hits ? 6604
Misses ? 1389
Partials ? 392 Continue to review full report at Codecov.
|
aeneasr
reviewed
May 26, 2022
aeneasr
requested changes
May 26, 2022
|
@icyphox ok, my branch is merged - now this one needs a few merge conflict resolutions 😓 |
https://godocs.io/context: > Do not pass a nil Context, even if a function permits it. Pass > context.TODO if you are unsure about which Context to use.
And fix go.mod.
aeneasr
pushed a commit
that referenced
this pull request
Jun 27, 2022
grantzvolsky
pushed a commit
that referenced
this pull request
Aug 1, 2022
aeneasr
pushed a commit
that referenced
this pull request
Aug 1, 2022
aeneasr
pushed a commit
that referenced
this pull request
Aug 18, 2022
aeneasr
pushed a commit
that referenced
this pull request
Sep 5, 2022
aeneasr
pushed a commit
that referenced
this pull request
Sep 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds tracing to persisters, requests and other components.